Conversation
…api-sqlmodel, fastapi-llm-agent template, fix bugs
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bnbong
added
documentation
|
✅ Template Inspection Passed All changed templates have been validated successfully. Last updated: 2026-09-04T08:55:09.731Z |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7daf801454
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| layout = resolve_project_layout(project_dir) | ||
| src_dir = layout["package_dir"] |
There was a problem hiding this comment.
When addroute targets the default domain-starter preset or any new src/app/main.py template, this places the generated CRUD and schema modules under src/app, but the route template still imports src.crud.<route> and src.schemas.<route>. Once the API router imports that route, application startup fails with ModuleNotFoundError; pass the resolved package module into route generation and render imports such as src.app.crud....
Useful? React with 👍 / 👎.
| name: str | None = Field(default=None, min_length=1, max_length=128) | ||
| description: str | None = Field(default=None, max_length=512) | ||
| price: float | None = Field(default=None, ge=0) | ||
| in_stock: bool | None = None |
There was a problem hiding this comment.
The PATCH schema accepts explicit null for name, price, and in_stock, even though the corresponding Item columns are non-nullable. Because CRUDBase.update() uses exclude_unset=True, these supplied nulls are written rather than ignored, causing an IntegrityError and a 500 response for requests such as PATCH {"name": null}. Keep only description nullable or otherwise validate/skip nulls for the required columns.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
1 participant
Requesting Merging
Description
v1.4.0: reproducible non-interactive generation, a fully working interactive builder, three new templates, safer scaffolding, and a rebuilt template QA pipeline.
Type of Change
Test Environment
pytest: 781 passed · mypy strict / black / isort clean ·mkdocs build --strictOKscripts/inspect-templates.py --offline: 11/11 templates pass (fastapi-psql-ormneeds Docker, verify in CI)startdemo fastapi-sqlmodelandinit --config(PostgreSQL+JWT+Celery+Redis+Alembic+ruff+Docker) generate, install, import and pass their own testsMajor Changes
init --config/--save-config(schema-validated),--dry-run,--no-venv,--no-install,--yes[tool.fastapi-fastkit]metadata block;runserver/addrouteare layout-aware via anchors + AST fallbackmigrations,tooling,loggingfastapi-auth-jwt,fastapi-sqlmodel,fastapi-llm-agent;fastapi-dockerized/fastapi-async-cruddeprecatedcli.initextracted intoProjectScaffolder; inspector split intobackend/inspectionwith real uvicorn smoke testssetup.py-tpland self-dependency removed, pins refreshedScreenshots (optional)
N/A
Etc
Breaking:
setup.py-tplremoved, no runtime dependency onFastAPI-fastkit, no automaticpipupgrade, auto-detection prefersuv, inspector API takesInspectionOptions. See CHANGELOG v1.4.0.