Skip to content

docs(engine): note why TryFromJs omits f32 - #5455

Open
AayushMainali-Github wants to merge 2 commits into
boa-dev:mainfrom
AayushMainali-Github:docs/try-from-js-f32
Open

docs(engine): note why TryFromJs omits f32#5455
AayushMainali-Github wants to merge 2 commits into
boa-dev:mainfrom
AayushMainali-Github:docs/try-from-js-f32

Conversation

@AayushMainali-Github

@AayushMainali-Github AayushMainali-Github commented Jul 25, 2026

Copy link
Copy Markdown

Summary

Test plan

Make the intentional omission discoverable so users convert via f64
(or from_js_with / to_f32) instead of filing another issue.
@AayushMainali-Github
AayushMainali-Github requested a review from a team as a code owner July 25, 2026 08:29
@github-actions github-actions Bot added the Waiting On Review Waiting on reviews from the maintainers label Jul 25, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jul 25, 2026
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,073 51,073 0
Ignored 1,482 1,482 0
Failed 570 570 0
Panics 0 0 0
Conformance 96.14% 96.14% 0.00%

Tested main commit: 4fc75c6ae9d85f2b8065c6716f88e9b35318438c
Tested PR commit: 61821e3e8c3dd292558e4c7c82032faf0067fe0a
Compare commits: 4fc75c6...61821e3

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.88%. Comparing base (6ddc2b4) to head (61821e3).
⚠️ Report is 1012 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5455       +/-   ##
===========================================
+ Coverage   47.24%   62.88%   +15.63%     
===========================================
  Files         476      530       +54     
  Lines       46892    59102    +12210     
===========================================
+ Hits        22154    37165    +15011     
+ Misses      24738    21937     -2801     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants