refactor: thread MutationContext token, resolve Gc borrow conflicts in environments - #5460
Draft
shruti2522 wants to merge 7 commits into
Draft
refactor: thread MutationContext token, resolve Gc borrow conflicts in environments#5460shruti2522 wants to merge 7 commits into
shruti2522 wants to merge 7 commits into
Conversation
github-actions
Bot
added
C-Tests
shruti2522
changed the title
Test262 conformance changes
Broken tests (1):Tested main commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #5458
Implemented next part of the oscars GC migration.
Context::gc()to wrap token access. in the final phases of integration, we would only have to update this one spot.MutationContextby value into the environments api (push_lexical,push_function, etc)evalandjsonmodules