[API] Implement Ephemeron and WeakGc API enhancements - #97
Merged
Conversation
nekevss
reviewed
Aug 5, 2026
| /// | ||
| /// Must only be called by the garbage collector. | ||
| #[inline] | ||
| unsafe fn trace_non_roots(&self) {} |
Member
There was a problem hiding this comment.
question: what's the reason for this API being added in? Is it just to align with the current boa_gc::Trace trait? If so, then we should ideal mark this with a TODO: remove in the future if we are expecting to remove it after integration is complete
shruti2522
marked this pull request as ready for review
August 10, 2026 02:33
shruti2522
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #96 (which is stacked on #95)
?Sizedbounds forEphemeronandWeakGcin the null collector.new,key,value,has_valuetoEphemeronandnew,is_upgradabletoWeakGcTraceimplementations for both types to use the newunsafe fn trace(&self)contract.dummy()andglobal()tonull_collector_branded::MutationContextDebug,PartialEq, andEqforWeakGc