Skip to content

[API] Implement missing Gc API in branded collector #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shruti2522 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[API] Implement missing Gc API in branded collector #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a72bc2
feat: enhance Trace trait with trace_non_roots and run_finalizer and …
shruti2522 Aug 3, 2026
06e96ed
feat: implement Ephemeron and WeakGc API enhancements
shruti2522 Aug 3, 2026
b218a82
feat(gc): implement missing Gc API and trace bounds for boa_engine in…
shruti2522 Aug 10, 2026
29b5dd3
fix: use core::ptr instead of std::ptr for no_std compatibility
shruti2522 Aug 10, 2026
5e7b02f
fix(gc): allow DST keys in Ephemeron methods
shruti2522 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 98 additions & 19 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions oscars/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ hashbrown = "0.16.1"
oscars_derive = { path = "../oscars_derive", version = "0.1.0" }
rustc-hash = "2.1.1"
thin-vec = { version = "0.2", optional = true }
# Optional Trace/Finalize impls for external types.
icu_locale_core = { version = "2.2.0", default-features = false, optional = true }
either = { version = "1.16.0", optional = true }
arrayvec = { version = "0.7.6", optional = true }

[dev-dependencies]
criterion = { version = "0.5", features = ["html_reports"] }
Expand Down Expand Up @@ -39,3 +43,6 @@ mark_sweep_branded = ["mark_sweep"]
null_collector = ["mark_sweep"]
null_collector_branded = ["mark_sweep"]
thin-vec = ["dep:thin-vec", "mark_sweep"]
icu = ["dep:icu_locale_core", "mark_sweep"]
either = ["dep:either", "mark_sweep"]
arrayvec = ["dep:arrayvec", "mark_sweep"]
5 changes: 1 addition & 4 deletions oscars/src/alloc/mempool3/alloc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,7 @@ impl<'pool, T: ?Sized> PoolPointer<'pool, T> {
self.0
}

pub fn to_erased(self) -> ErasedPoolPointer<'pool>
where
T: Sized,
{
pub fn to_erased(self) -> ErasedPoolPointer<'pool> {
ErasedPoolPointer(self.0.cast::<u8>(), PhantomData)
}

Expand Down
21 changes: 21 additions & 0 deletions oscars/src/collectors/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,24 @@ impl<T: Finalize> Finalize for OnceCell<T> {}
impl<T: ToOwned + Finalize + ?Sized> Finalize for Cow<'static, T> where T::Owned: Finalize {}

impl<T> Finalize for PhantomData<T> {}

#[cfg(feature = "icu")]
impl Finalize for icu_locale_core::LanguageIdentifier {}

#[cfg(feature = "icu")]
impl Finalize for icu_locale_core::Locale {}

#[cfg(feature = "either")]
impl<L: Finalize, R: Finalize> Finalize for either::Either<L, R> {}

#[cfg(feature = "arrayvec")]
impl<T: Finalize, const N: usize> Finalize for arrayvec::ArrayVec<T, N> {}

#[cfg(feature = "std")]
impl Finalize for std::path::Path {}
#[cfg(feature = "std")]
impl Finalize for std::path::PathBuf {}
#[cfg(feature = "std")]
impl Finalize for std::time::Instant {}
#[cfg(feature = "std")]
impl Finalize for std::time::SystemTime {}
Loading