Address 3.3.0 review: BLAS64 gating, infinity validation, lin_sys_solver, CI/test fixes - #230
Merged
Conversation
This was referenced Aug 30, 2026
|
Will this address the following error that I see with scs 3.3.0 or should I open a new issue? |
bodono
added a commit
that referenced
this pull request
Aug 31, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
added a commit
that referenced
this pull request
Aug 31, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
added a commit
that referenced
this pull request
Aug 31, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
added a commit
that referenced
this pull request
Aug 31, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
force-pushed
the
fix/review-batch
branch
from
August 31, 2026 22:19
b6f7bc6 to
f5028a1
Compare
bodono
added a commit
that referenced
this pull request
Aug 31, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
added a commit
that referenced
this pull request
Sep 1, 2026
Moves the scs/py_ctrlc.c legacy-build wiring here from #230: the file is introduced by this PR, so the branch that references it must be the one that contains it.
bodono
force-pushed
the
fix/review-batch
branch
from
September 3, 2026 19:51
2ea0cec to
73d35e1
Compare
bodono
force-pushed
the
fix/review-batch
branch
3 times, most recently
from
September 3, 2026 21:07
2ca97c6 to
90e7010
Compare
bodono
force-pushed
the
fix/wheels-openblas-423
branch
from
September 3, 2026 21:17
1442623 to
8e12289
Compare
bodono
force-pushed
the
fix/review-batch
branch
3 times, most recently
from
September 4, 2026 11:36
195d884 to
aad08cc
Compare
- acceleration_regularization: only non-finite values are invalid; the sign selects the mode per the core contract (negative = pinned). - eps_*, time_limit_secs: reject +inf like the core (!isfinite) with setting-specific messages; 0 disables the time limit. - info gains lin_sys_solver, the backend that actually ran. - use_blas64 without link_mkl is refused at configure time: declaring ILP64 against an LP64 system BLAS corrupts every BLAS call. The legacy setup script refuses --blas64 for the same reason. - Drop the unrecognized faulthandler_exit_on_timeout pytest option. - README: acceleration_interval default is 5; BLAS64 needs link_mkl. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
build_mkl runs an LP64 solve under an MKL-backed NumPy, the ILP64 interface-layer guard under that same NumPy (a checked-in probe), and an ILP64 solve under an OpenBLAS NumPy, instead of every Python version times both widths; the solver name is asserted in the MKL test itself. The OpenMP, Accelerate and native-arch source lanes run one configuration each; the wheel matrix already covers every Python ABI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
bodono
force-pushed
the
fix/review-batch
branch
from
September 4, 2026 16:49
aad08cc to
cb01c12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of the scs-python findings from the 3.3.0 review, excluding the removed-kwargs shim (intentionally skipped) and the SIGINT interrupt manager (separate PR):
use_blas64=truewithoutlink_mkl=truedeclared ILP64 integer widths against LP64 system BLAS — memory corruption by configuration (the review measured 20 spectral failures under Accelerate). Meson now rejects the combination with a clear error; README example fixed.eps_*/time_limit_secsthat core then rejected with a misleading generic error. The wrapper now mirrors core's!isfinitewith per-setting messages (time_limit_secs=0remains the no-limit spelling).info['lin_sys_solver']exposed — with AUTO choosing invisibly (and preferring MKL in standard wheels), the chosen backend is now inspectable (verified: returns e.g.'sparse-direct-amd-qdldl').acceleration_intervaldefault corrected to 5.Stacked on #232.
🤖 Generated with Claude Code