docs: complete pull request workflow - #9
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe pull request updates repository guidance for ChangesPR workflow guidance
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/pull_request_template.md:
- Line 16: Update the git diff --check command in
.github/pull_request_template.md at line 16, CONTRIBUTING.md at line 71, and
AGENTS.md at line 524 to inspect staged changes using git diff --cached --check
(or the complete pending diff with git diff HEAD --check), keeping all three
locations consistent.
In `@AGENTS.md`:
- Line 523: Use one fork-aware canonical remote consistently throughout the
workflow: update AGENTS.md lines 523-523 to use the selected canonical remote
when creating the feature branch, update CONTRIBUTING.md lines 108-115 to fetch
and fast-forward from that same remote when working from a fork, and update
AGENTS.md lines 528-528 to reuse it for post-merge synchronization. Keep the
existing distinction between requested state-changing actions unchanged.
- Line 529: Update the release verification guidance near the release workflow
checks to require comparing the release tag target with the exact intended
merged commit, rather than only verifying that tag_commit is an ancestor of
origin/$DEFAULT_BRANCH. Alternatively, narrow the claim in AGENTS.md so it no
longer asserts exact merged-commit verification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c2679ef-dc54-4aa3-a915-bbb853df2ac5
📒 Files selected for processing (3)
.github/pull_request_template.mdAGENTS.mdCONTRIBUTING.md
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
git diff --checkto contributor and PR checklistsWhy
The existing guidance described the repository gates, but it did not fully capture the review-fix loop, latest-head merge guard, post-merge synchronization, or the distinction between requested GitHub state changes. This made it possible for an Agent to stop early or merge based on stale review state.
Validation
bun run typecheckbun run testbun run buildwhen the production package or Web UI is affected — not required for documentation-only changesgit diff --checkDocumentation and security
Related issue
None
Summary by CodeRabbit