[3.6] Make the bootstrap more robust#7763
Conversation
|
This currently breaks being compatible with PHP 5.5.9, however the unittests didn't work properly with PHP 5.5.9 anyway due to the lower phpunit version. |
|
Do you think you could get this fixed for PHP 5.5.9? For Bolt 3, we'd need to keep compatible with that version, i'm afraid. |
|
@bobdenotter if you really want to keep supporting 5.5.9 I would suggest reverting this PR and rewrite |
|
@StevendeVries We use SemVer, so we cannot drop PHP 5.5.9 support for Bolt 3. Only in a major release can we bump the minimum requirements. PHPUnit 5.7 should work on PHP 5.5.9 too, right? |
|
Like stated in the ci: |
|
I'll remove the phpunit version increase to keep the bootstrap changes. Making it possible for you to merge. |
3c75118 to
3be0383
Compare
|
Thanks, mate! 👍 |
When using an old version of phpunit like
4.8.28it does not provide a class calledPHPUnit\Framework\TestCaserequired bybolt/bolt/tests/phpunit/unit/BoltUnitTest.phpThe class is available in version 5.7. The dependancy with
phpunit/php-code-coveragehas also been updated.Next to the phpunit version there is an issue when running the unittests, it can't seem to find the
vendor/autoload.php. I've made the bootstrap a bit more defensive.For context: We have the bootstrap located in:
vendor/bolt/bolt/tests/phpunit/bootstrap.php