Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Symfony 5 #1182

Closed
5 tasks done
bobdenotter opened this issue Mar 14, 2020 · 5 comments · Fixed by #1546
Closed
5 tasks done

Update to Symfony 5 #1182

bobdenotter opened this issue Mar 14, 2020 · 5 comments · Fixed by #1546

Comments

@bobdenotter
Copy link
Member

bobdenotter commented Mar 14, 2020

Currently, Bolt 4 uses SF 4 components. We should bump these to v5.

@bobdenotter bobdenotter added this to the Bolt 4.1 milestone Mar 14, 2020
@bobdenotter
Copy link
Member Author

bobdenotter commented Apr 11, 2020

Behat / MinkBrowserKitDriver needs to be updated, but it seems work is underway:

minkphp/MinkBrowserKitDriver#142
Behat/Symfony2Extension#157

alternatively, see if we can use this (as is also used by Sylius):

https://github.com/FriendsOfBehat/MinkExtension

@bobdenotter
Copy link
Member Author

bobdenotter commented Apr 11, 2020

@bobdenotter
Copy link
Member Author

bobdenotter commented Jun 13, 2020

Other findings:

We need to fix deprecations:

!!
!!  Fatal error: Uncaught TypeError: Argument 2 passed to Symfony\Component\DependencyInjection\ContainerBuilder::set() must be an object or null, array given, called in /foo/src/Kernel.php on line 95 and defined in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php:484
!!  Stack trace:
!!  #0 /foo/src/Kernel.php(95): Symfony\Component\DependencyInjection\ContainerBuilder->set('bolt.config.gen...', Array)
!!  #1 /foo/src/Kernel.php(64): Bolt\Kernel->setBoltParameters(Object(Symfony\Component\DependencyInjection\ContainerBuilder), '/Users/bob/Site...')
!!  #2 /foo/vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php(118): Bolt\Kernel->configureContainer(Object(Symfony\Component\DependencyInjection\ContainerBuilder), Object(Symfony\Component\Config\Loader\DelegatingLoader))
!!  #3 /foo/vendor/symfony/dependency-injection/Loader/ClosureLoader.php(38): Bolt\Kernel->Symfony\Bundle\FrameworkBundle\Kernel in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php on line 484
!!  PHP Fatal error:  Uncaught TypeError: Argument 2 passed to Symfony\Component\DependencyInjection\ContainerBuilder::set() must be an object or null, array given, called in /foo/src/Kernel.php on line 95 and defined in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php:484
!!  Stack trace:
!!  #0 /foo/src/Kernel.php(95): Symfony\Component\DependencyInjection\ContainerBuilder->set('bolt.config.gen...', Array)
!!  #1 /foo/src/Kernel.php(64): Bolt\Kernel->setBoltParameters(Object(Symfony\Component\DependencyInjection\ContainerBuilder), '/Users/bob/Site...')
!!  #2 /foo/vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php(118): Bolt\Kernel->configureContainer(Object(Symfony\Component\DependencyInjection\ContainerBuilder), Object(Symfony\Component\Config\Loader\DelegatingLoader))
!!  #3 /foo/vendor/symfony/dependency-injection/Loader/ClosureLoader.php(38): Bolt\Kernel->Symfony\Bundle\FrameworkBundle\Kernel in /foo/vendor/symfony/dependency-injection/ContainerBuilder.php on line 484

And remove doctrine/doctrine-cache-bundle:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for symfony/security-bundle ^5.1 -> satisfiable by symfony/security-bundle[v5.1.0, v5.1.1].
    - doctrine/doctrine-cache-bundle 1.4.0 requires symfony/doctrine-bridge ^3.4|^4.0 -> satisfiable by symfony/doctrine-bridge[v4.4.10].
    - doctrine/doctrine-cache-bundle 1.4.0 requires symfony/doctrine-bridge ^3.4|^4.0 -> satisfiable by symfony/doctrine-bridge[v4.4.10].
    - Conclusion: remove symfony/doctrine-bridge v4.4.10
    - Installation request for doctrine/doctrine-cache-bundle ^1.4 -> satisfiable by doctrine/doctrine-cache-bundle[1.4.0].
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In Configuration.php line 40:
!!
!!    Option "exception_controller" under "twig" must be null or unset, use "erro
!!    r_controller" under "framework" instead.
!!
!!
!!
Script @auto-scripts was called via post-update-cmd

@bobdenotter
Copy link
Member Author

bobdenotter commented Jun 15, 2020

New one:

Fatal error: Uncaught Error: Class 'Symfony\Component\Debug\Debug' not found in /Users/bob/Sites/bolt/core/public/index.php:26 Stack trace: #0 {main} thrown in /Users/bob/Sites/bolt/core/public/index.php on line 26

@bobdenotter
Copy link
Member Author

bobdenotter commented Jun 15, 2020

Making progress.. Seems the only blocker is now Behat:

Screenshot 2020-06-15 at 11 00 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant