search/setcontent on Select fields with "multiple: true"

[JTNMW]

When using search, setcontent or url query on taxonomy fields or select fields with 'multiple: true', with more than one entry eg ["love", "Music", "Movies"] only the first values in these fields are searchable.

search on "love" would return results, search on "music" or "Movies" returns no content.
This bug occurs at both frontend (set content, search, url query) and backend in filter on content listing.

In selectQuery.php changing

$newLeftExpression = JsonHelper::wrapJsonFunction($translationsAlias . '.value', null, $em->getConnection());

to

$newLeftExpression = $translationsAlias . '.value';

resolves the issue, but causes issues errors elsewhere.

Details

Question	Answer
Relevant Bolt Version	legacy / 4.0 / 4.1 / master
Install type	Zip or tar install / Composer install / GitHub checkout
BC Break	yes/no
PHP version	7.2 / 7.3 / 7.4
Web server	Apache / Nginx / Built-in, version [ version ]
For UX/UI issues	Browser name and version

Reproduction

If you're filing a bug, please describe how to reproduce it. Include as much
relevant information as possible, such as:

Bug summary

Specifics

Steps to reproduce

Expected result

Actual result

[bobdenotter]

Hmm, right.. This is not trivial to fix, i think. Marked as "bug", so it'll stay on the list!

[JTNMW]

ive managed find a fix for this issue, though im not sure if there might be more elegant solution:

changes to selectQuery.php

changes to config/packages/doctrine.yaml

this resolves issues frontend when filtering and %setcontent% for select fields with multiple entries, and all taxonomies (tags, catagories) with multiple entries.

Ive also made changes to contentRepository.php and frontend/ListingController.php to enable taxonomy entries to be included in searchNaive. This is only effective Frontend, but would be useful for backend filtering if possible.

contentRepository.php

  $qb->addSelect('f')
            ->innerJoin('content.fields', 'f')
            ->innerJoin('f.translations', 't')
            ->andWhere($qb->expr()->like('LOWER(t.value)', 'LOWER(:search)'))
            ->setParameter('search', $searchTerm . '%')

            //ACNMW - added to incude taxonomies to be searched
            ->addSelect('tx')
            ->innerJoin('content.taxonomies', 'tx')
            ->orWhere($qb->expr()->like('tx.slug', ':slug'))
            ->setParameter('slug', '%' . $searchTerm . '%');`

Frontend/listingController.php

public function listing(ContentRepository $contentRepository, Request $request, string $contentTypeSlug): Response
    {
        $contentType = ContentType::factory($contentTypeSlug, $this->config->get('contenttypes'));
        $page = (int) $request->query->get('page', 1);
        $amountPerPage = $contentType->get('listing_records');
         //get all query parameters
		$params = $request->query->all();
		
		
		//check if search is set and move to anyField param with like %...% appended.
		if( $request->query->get('search') !='') { $params['anyField'] = '%'.$request->query->get('search').'%';
            //clear search param 
            unset ($params ['search']);};
		
		
		//get published records only
		$params ['status'] = 'published';
		
		//set order defaults if not set in query
        $params ['order'] = $request->query->get('order', $contentType->get('order'));
      
		 if (! empty($params['anyField'])) {
             $contentTypes = $this->config->get('contenttypes')->where('searchable', true);
             
            $records = $contentRepository->searchNaive($params['anyField'], $page, $amountPerPage, $contentTypes);
        } else {
            // include all params as array
		$records = $this->query->getContent($contentTypeSlug, $params)
            ->setMaxPerPage($amountPerPage)
            ->setCurrentPage($page);
        }
		
		

        /*
        $order = $request->query->get('order', $contentType->get('order'));

        $records = $this->query->getContent($contentTypeSlug, [
            'status' => 'published',
            'order' => $order,
        ])
            ->setMaxPerPage($amountPerPage)
            ->setCurrentPage($page);*/

        $templates = $this->templateChooser->forListing($contentType);

        $twigVars = [
            'records' => $records,
            $contentType->getSlug() => $records,
            'contenttype' => $contentType,
        ];

        return $this->renderTemplate($templates, $twigVars);
    }
}

are these changes beneficial worthy of a PR?

[bobdenotter]

Hi @JTNMW,

Yes, please make a PR! I'd think this is a good approach, and would like to test it out!

[bobdenotter]

Fixed in #1541 and #1619