Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Sanitizer obey rules from config.yml #564

Closed
bobdenotter opened this issue Aug 5, 2019 · 1 comment · Fixed by #1648
Closed

Make Sanitizer obey rules from config.yml #564

bobdenotter opened this issue Aug 5, 2019 · 1 comment · Fixed by #1648

Comments

@bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Aug 5, 2019

No description provided.

@I-Valchev
Copy link
Member

@I-Valchev I-Valchev commented Nov 8, 2019

Issue with implementing this:

The Sanitiser gets instantiated within the getTwigValue() method of the Field entity, meaning that the $config cannot be autowired to an entity. Also, the $config cannot be passed from the Content class, because by the time getTwigValue() is called in Twig ({{ field.twigValue() }}), the Content is no longer accessible.

The problem is how to pass the config to the getTwigValue() method, which will instantiate the Sanitiser with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants