Skip to content

Add missing labels to bulk actions #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 3 commits into from
Apr 16, 2020
Merged

Add missing labels to bulk actions #1302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61414c2
Add missing labels to bulk actions
I-Valchev Apr 16, 2020
5522073
Replace "Update all" to "Apply to all" in tests
I-Valchev Apr 16, 2020
91a0337
hehe (-:
I-Valchev Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/e2e/bulk_actions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ Feature: Bulk content listing actions

Then I should see "8 Pages Selected" in the ".admin__body--aside .card-header" element
And I should see "Select option" in the ".admin__body--aside .card-body .multiselect" element
And I should see "Update all"
And the 1st "Update all" button should be disabled
And I should see "Apply to all"
And the 1st "Apply to all" button should be disabled

@javascript

Expand All @@ -28,9 +28,9 @@ Feature: Bulk content listing actions
# When I click "Change status to 'draft'"
When I click "aside .card-body .multiselect__content-wrapper > ul > li:nth-child(2)"
And I wait 0.1 second
Then the 1st "Update all" button should be enabled
Then the 1st "Apply to all" button should be enabled

When I press "Update all"
When I press "Apply to all"

Then I should be on "/bolt/content/tests"
And I should see 8 ".listing__records .is-meta .status.is-draft" elements
Expand All @@ -43,11 +43,12 @@ Feature: Bulk content listing actions
# And I click "Change status to 'publish'"
And I click "aside .card-body .multiselect__content-wrapper > ul > li:nth-child(1)"
And I wait 0.1 second
Then the 1st "Update all" button should be enabled
Then the 1st "Apply to all" button should be enabled

When I press "Update all"
When I press "Apply to all"

Then I should be on "/bolt/content/tests"
And I should see 8 ".listing__records .is-meta .status.is-published" elements
And I should not see an ".listing__records .is-meta .status-is-draft" element
And I should not see an ".listing__records .is-meta .status.is-held" element
And I should not see an ".listing__records .is-meta .status.is-held" element
And I should see "Status changed successfully"
16 changes: 14 additions & 2 deletions translations/messages.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2184,7 +2184,7 @@
<unit id="WeJxw6Z" name="action.update_all">
<segment>
<source>action.update_all</source>
<target>Update all</target>
<target>Apply to all</target>
</segment>
</unit>
<unit id="QVRwwK4" name="about.system_info">
Expand Down Expand Up @@ -2252,12 +2252,24 @@
<source>file.delete_confirm</source>
<target>Are you sure you wish to delete this file?</target>
</segment>
</unit>
</unit>
<unit id="IWbf2by" name="listing.title_filterby">
<segment>
<source>listing.title_filterby</source>
<target>Filter by</target>
</segment>
</unit>
<unit id="Zssh7In" name="content.status_changed_successfully">
<segment>
<source>content.status_changed_successfully</source>
<target>Status changed successfully</target>
</segment>
</unit>
<unit id="GOhQBY9" name="content.deleted_successfully">
<segment>
<source>content.deleted_successfully</source>
<target>Content deleted successfully</target>
</segment>
</unit>
</file>
</xliff>