Skip to content

Backend menu caches localized #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 1 commit into from
Apr 22, 2020
Merged

Backend menu caches localized #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Menu/CachedBackendMenuBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Bolt\Menu;

use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Contracts\Cache\CacheInterface;

final class CachedBackendMenuBuilder implements BackendMenuBuilderInterface
Expand All @@ -14,15 +15,21 @@ final class CachedBackendMenuBuilder implements BackendMenuBuilderInterface
/** @var BackendMenuBuilderInterface */
private $menuBuilder;

public function __construct(BackendMenuBuilderInterface $menuBuilder, CacheInterface $cache)
/** @var RequestStack */
private $requestStack;

public function __construct(BackendMenuBuilderInterface $menuBuilder, CacheInterface $cache, RequestStack $requestStack)
{
$this->cache = $cache;
$this->menuBuilder = $menuBuilder;
$this->requestStack = $requestStack;
}

public function buildAdminMenu(): array
{
return $this->cache->get('backendmenu', function () {
$locale = $this->requestStack->getCurrentRequest()->getLocale();
$cacheKey = 'backendmenu_' . $locale;
return $this->cache->get($cacheKey, function () {
return $this->menuBuilder->buildAdminMenu();
});
}
Expand Down