Add ability to override routing with record_route

[I-Valchev]

Fixes #1483
Fixes #1470

One outstanding issue:

termsandconditions:
  path: /terms-and-conditions
  defaults:
    _controller: Bolt\Controller\Frontend\DetailController::record
    contentTypeSlug: 'terms-and-conditions'
    slugOrId: 31

The default slugOrId is set here.
Trying to get the |link on the /terms-and-conditions page breaks the url, because the ContentExtension::getLink always overrides the slugOrId param, hence the link becomes:
/terms-and-conditions?slugOrId=someUnexpectedSlug

where someUnexpectedSlug is the slug from the content.

I'm not sure how to fix this elegantly? @bobdenotter

[bobdenotter]

I see the problem!

First, it works for the generated canonical just fine, it seems:

But, it doesn't work correctly when using {{ record|link }}:

This is because it's configured with some defaults, and then you generate a route for something that has different values for these specific things. This is undesirable, but it's also the correct behaviour, I think.

If i'd set those values as defaults (and make sure there's an entry with slug terms-and-conditions), it doesn't add them:

termsandconditions:
  path: /terms-and-conditions
  defaults:
    _controller: Bolt\Controller\Frontend\DetailController::record
    contentTypeSlug: 'entry'
    slugOrId: terms-and-conditions

I think this is not something we can fix, but it does have a workaround..

What's more annoying is the following:

content_seo:
   path: /{slugOrId}
   methods: [GET|POST]
   defaults:
     _controller: Bolt\Controller\Frontend\DetailController::record

That'll make any /lorem-ipsum work, but if i add record_route: content_seo, the result of {{ record|link }} is /.. There it doesn't substitute the slugOrId, while it really should do that.

[I-Valchev]

I see now!
Yeah that makes sense, if it's configured in routes.yaml with the slug and not ID, they are the same, so no query params.

I am not sure I could replicate the content_seo example. You say that any /lorel-ipsum should work, but for me when I try anything site.wip/lorem-ipsum it says content not found. Which I think makes sense given the controller:

        if (is_numeric($slugOrId)) { // THIS IS FALSE
            $record = $this->contentRepository->findOneBy(['id' => (int) $slugOrId]);
        } else {
           // $contentTypeSlug is null here?
            $contentType = ContentType::factory($contentTypeSlug, $this->config->get('contenttypes'));
            $record = $this->contentRepository->findOneBySlug($slugOrId, $contentType);
        }

        return $this->renderSingle($record, $requirePublished);

I was able to get it working if I change ContentRepository::findOneBySlug on line 146 from if ($contentType) { to
if ($contentType && $contentType->get('slug')) {

And then the |link is /aut-error-cupiditate-magnam?contentTypeSlug=blog-post

[bobdenotter]

And then the |link is /aut-error-cupiditate-magnam?contentTypeSlug=blog-post

Still, that's better than it was before. If you fix the tests (seems pretty straightforward in this case), let's merge and move to the next item on the list for now! :-)

[bobdenotter]

Neat! 🥃