Skip to content

Fix issue with undefined index 0 for a select field inside a a set #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 1 commit into from
Jun 26, 2020
Merged

Fix issue with undefined index 0 for a select field inside a a set #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Controller/Backend/ContentEditController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,11 +420,6 @@ private function updateField(Field $field, $value, ?string $locale): void
$field->setLocale($this->defaultLocale);
}

// If the value is an array that contains a string of JSON, parse it
if (is_iterable($value) && Json::test(current($value))) {
$value = Json::findArray($value);
}

if ($field instanceof SetField) {
foreach ($value as $name => $svalue) {
$child = $field->getValueForEditor()[$name];
Expand All @@ -438,6 +433,11 @@ private function updateField(Field $field, $value, ?string $locale): void
$this->updateField($child, $svalue, $locale);
}
} else {
// If the value is an array that contains a string of JSON, parse it
if (is_iterable($value) && Json::test(current($value))) {
$value = Json::findArray($value);
}

$field->setValue($value);
}

Expand Down