Skip to content

Pass on Query parameters to subrequest from Homepage#1645

Merged
I-Valchev merged 1 commit intomasterfrom
fix/pass-on-query-params-to-subrequest
Jul 23, 2020
Merged

Pass on Query parameters to subrequest from Homepage#1645
I-Valchev merged 1 commit intomasterfrom
fix/pass-on-query-params-to-subrequest

Conversation

@bobdenotter
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobdenotter nice one! Wonder how you found out about it?

@I-Valchev I-Valchev merged commit 2676929 into master Jul 23, 2020
@I-Valchev I-Valchev deleted the fix/pass-on-query-params-to-subrequest branch July 23, 2020 17:25
@bobdenotter
Copy link
Copy Markdown
Member Author

Wonder how you found out about it?

@I-Valchev I updated phpnews.io to the latest, and discovered the frontpage wasn't paginating anymore.

Took longer than I care to admit what was causing the page parameter not too show up in the subrequest. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants