Skip to content

Fix deprecation in RouteCollectionBuilder#1815

Merged
I-Valchev merged 1 commit intomasterfrom
deprecation-fix-RouteCollectionBuilder
Sep 2, 2020
Merged

Fix deprecation in RouteCollectionBuilder#1815
I-Valchev merged 1 commit intomasterfrom
deprecation-fix-RouteCollectionBuilder

Conversation

@bobdenotter
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code, up-to-date code! 👍

@I-Valchev I-Valchev merged commit 3ff64ca into master Sep 2, 2020
@I-Valchev I-Valchev deleted the deprecation-fix-RouteCollectionBuilder branch September 2, 2020 15:26
@XWB
Copy link
Copy Markdown

XWB commented Sep 8, 2020

@bobdenotter This change results in the following error:

Argument 1 passed to Bolt\Kernel::configureRoutes() must be an instance of Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator, instance of Symfony\Component\Routing\RouteCollectionBuilder given, called in vendor/symfony/framework-bundle/Kernel/MicroKernelTrait.php on line 93

Symfony 4.4.13

@bobdenotter
Copy link
Copy Markdown
Member Author

@XWB Could you update to SF 5? I assume you're on an older 4.0 beta/RC that you've ran composer update on, right?

See here: https://github.com/bolt/project/blob/master/composer.json#L48-L54

@XWB
Copy link
Copy Markdown

XWB commented Sep 8, 2020

@bobdenotter Thanks, you're right. Updating to Symfony 5.1 resolves my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants