Imagelists and Filelists work in collections

.travis.yml

@@ -72,7 +72,7 @@ script:
   # run API tests
   - make behat-api-quiet
   # run JS e2e tests
-  - make behat-js-quiet
+  - travis_retry make behat-js-quiet
   # Upload Behat logs
   - ./vendor/bin/upload-textfiles "var/log/behat-reports/*.log"
 

assets/js/app/editor/Components/Filelist.vue

@@ -87,7 +87,8 @@ export default {
       return index === this.containerFiles.length - 1;
     },
     getFieldNumberFromElement(elem) {
-      return parseInt(elem.fieldName.match(/\d+/)[0]);
+      // get the last number because in collections, there are multiple.
+      return parseInt([...elem.fieldName.matchAll(/\d+/g)].splice(-1).pop()[0]);
     },
     onMoveFileDown(elem) {
       let fieldNumber = this.getFieldNumberFromElement(elem);

assets/js/app/editor/Components/Imagelist.vue

@@ -95,7 +95,8 @@ export default {
       });
     },
     getFieldNumberFromElement(elem) {
-      return parseInt(elem.fieldName.match(/\d+/)[0]);
+      // get the last number because in collections, there are multiple.
+      return parseInt([...elem.fieldName.matchAll(/\d+/g)].splice(-1).pop()[0]);
     },
     onMoveImageDown(elem) {
       let fieldNumber = this.getFieldNumberFromElement(elem);

ecs.php

@@ -46,7 +46,7 @@
 return static function (ContainerConfigurator $containerConfigurator): void {
     $parameters = $containerConfigurator->parameters();
 
-    $parameters->set('sets', ['clean-code', 'common', 'php-70', 'php-71', 'psr-12', 'symfony', 'symfony-risky']);
+    $parameters->set('sets', ['clean-code', 'common', 'php70', 'php71', 'psr12', 'symfony', 'symfony-risky']);
 
     $parameters->set('paths', [
         __DIR__ . '/src',

templates/helpers/_taxonomylinks.html.twig

@@ -9,7 +9,7 @@
             {% endif %}
         </em>
         {% for taxonomy in taxonomies %}
-            <a href="{{ taxonomy.link }}" class="taxonomy-{{ type }}">{{ taxonomy.name }}</a>{% if not loop.last %}, {% endif %}
+            <a href="{{ taxonomy|link }}" class="taxonomy-{{ type }}">{{ taxonomy.name }}</a>{% if not loop.last %}, {% endif %}
         {% else %}
             {{ __('general.phrase.none') }}
         {% endfor %}