Skip to content

Slugs in fixtures use the uses: attribute to make sensible slugs #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 1 commit into from
Sep 16, 2020
Merged

Slugs in fixtures use the uses: attribute to make sensible slugs #1861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 35 additions & 17 deletions src/DataFixtures/ContentFixtures.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ class ContentFixtures extends BaseFixture implements DependentFixtureInterface,
/** @var Generator */
private $faker;

/** @var string */
private $lastTitle = null;

/** @var array */
private $presetRecords = [];

Expand Down Expand Up @@ -109,9 +106,21 @@ private function loadContent(ObjectManager $manager): void
$content->setStatus($this->getRandomStatus());
}

foreach ($contentType['fields'] as $name => $fieldType) {
$fields = collect($contentType['fields']);

// Load all fields, except slugs.
$fields->filter(function ($field) {
return $field['type'] !== 'slug';
})->map(function ($fieldType, $name) use ($content, $contentType, $preset): void {
$this->loadField($content, $name, $fieldType, $contentType, $preset);
}
});

// Load slug fields, to make sure `uses` can be used.
$fields->filter(function ($field) {
return $field['type'] === 'slug';
})->map(function ($fieldType, $name) use ($content, $contentType, $preset): void {
$this->loadField($content, $name, $fieldType, $contentType, $preset);
});

foreach ($contentType['taxonomy'] as $taxonomySlug) {
if ($taxonomySlug === 'categories') {
Expand Down Expand Up @@ -180,7 +189,7 @@ private function loadField(Content $content, string $name, $fieldType, ContentTy
} elseif ($fieldType['type'] === 'set') {
$field = $this->loadSetField($content, $field, $contentType, $preset);
} else {
$field->setValue($this->getValuesforFieldType($name, $fieldType, $contentType['singleton']));
$field->setValue($this->getValuesforFieldType($fieldType, $contentType['singleton'], $content));
}
}
$field->setSortorder($sortorder++ * 5);
Expand All @@ -194,7 +203,7 @@ private function loadField(Content $content, string $name, $fieldType, ContentTy
$locales = $contentType['locales']->toArray();
foreach ($locales as $locale) {
if ($locale !== $this->defaultLocale && array_search($locale, $locales, true) !== count($locales) - 1) {
$value = $preset[$name] ?? $this->getValuesforFieldType($name, $fieldType, $contentType['singleton']);
$value = $preset[$name] ?? $this->getValuesforFieldType($fieldType, $contentType['singleton'], $content);
$field->translate($locale, false)->setValue($value);
}
}
Expand All @@ -212,15 +221,13 @@ private function getRandomStatus(): string
return $statuses[array_rand($statuses)];
}

private function getValuesforFieldType(string $name, DeepCollection $field, bool $singleton): array
private function getValuesforFieldType(DeepCollection $field, bool $singleton, Content $content): array
{
$data = isset($field['fixture_format']) ? $this->getFixtureFormatValues($field['fixture_format']) : $this->getFieldTypeValue($field, $singleton);

if ($name === 'title' || $name === 'heading') {
$this->lastTitle = $data;
}

return $data;
return
isset($field['fixture_format']) ?
$this->getFixtureFormatValues($field['fixture_format'])
:
$this->getFieldTypeValue($field, $singleton, $content);
}

private function getFixtureFormatValues(string $format): array
Expand All @@ -241,7 +248,7 @@ function ($match) {
)];
}

private function getFieldTypeValue(DeepCollection $field, bool $singleton)
private function getFieldTypeValue(DeepCollection $field, bool $singleton, Content $content)
{
$nb = $singleton ? 8 : 4;

Expand Down Expand Up @@ -282,7 +289,18 @@ private function getFieldTypeValue(DeepCollection $field, bool $singleton)

break;
case 'slug':
$data = $this->lastTitle ?? [$this->faker->sentence(3, true)];
if (isset($field['uses'])) {
$fields = collect($field['uses']);
$data = $fields->reduce(function (string $carry, string $current) use ($content) {
$value = $content->hasField($current) ? $content->getFieldValue($current) : '';

return $carry . $value;
}, '');
} else {
$data = $this->faker->sentence(3, true);
}

$data = [$data];

break;
case 'text':
Expand Down