Fix edit file in File management subfolders#1915
Merged
bobdenotter merged 2 commits intobolt:masterfrom Sep 28, 2020
Merged
Conversation
I-Valchev
requested changes
Sep 28, 2020
Member
I-Valchev
left a comment
There was a problem hiding this comment.
hi @denis-gorin , good stuff thanks for fixing it!
Looks like it needs a csfix, you can run that by running make csfix from the root folder of your clone, then push the changes and the tests should pass. Can you do that? :-)
Member
|
@denis-gorin maybe try to run this "manually"? |
Contributor
Author
yes, found it in README In Resolver.php line 110:
Service '0296': Class Symplify\CodingStandard\Rules\ForbiddenFuncCallRule not found. |
I-Valchev
approved these changes
Sep 28, 2020
Member
I-Valchev
left a comment
There was a problem hiding this comment.
@denis-gorin thanks, it looks good now! Let's wait for the last couple of tests to pass and we're good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1914