Skip to content

Fix edit file in File management subfolders#1915

Merged
bobdenotter merged 2 commits intobolt:masterfrom
denis-gorin:issue-1914-fix-listing-file-edit
Sep 28, 2020
Merged

Fix edit file in File management subfolders#1915
bobdenotter merged 2 commits intobolt:masterfrom
denis-gorin:issue-1914-fix-listing-file-edit

Conversation

@denis-gorin
Copy link
Copy Markdown
Contributor

Fixes #1914

  • add path for subfolder to delete/duplicate action
  • add path to return after action
  • replace success notification label for duplicate action

Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @denis-gorin , good stuff thanks for fixing it!

Looks like it needs a csfix, you can run that by running make csfix from the root folder of your clone, then push the changes and the tests should pass. Can you do that? :-)

@I-Valchev
Copy link
Copy Markdown
Member

@denis-gorin maybe try to run this "manually"?

bin/console c:c
vendor/bin/ecs check src
vendor/bin/ecs check tests/spec
vendor/bin/ecs check tests/php
vendor/bin/phpstan --memory-limit=1G analyse -c phpstan.neon src

@denis-gorin
Copy link
Copy Markdown
Contributor Author

vendor/bin/phpstan --memory-limit=1G analyse -c phpstan.neon src

yes, found it in README
already pushed
but last command (phpstan.neon) trow error:

In Resolver.php line 110:

  Service '0296': Class Symplify\CodingStandard\Rules\ForbiddenFuncCallRule not found.

@I-Valchev I-Valchev self-requested a review September 28, 2020 09:20
Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denis-gorin thanks, it looks good now! Let's wait for the last couple of tests to pass and we're good to merge.

Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing! 👍

@bobdenotter bobdenotter merged commit 4b19199 into bolt:master Sep 28, 2020
@bobdenotter bobdenotter changed the title fix edit file in File management subfolders Fix edit file in File management subfolders Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File management: deleting/duplicating files in a subfolder

3 participants