Add new bolt:reset-password CLI command to reset password#1937
Merged
bobdenotter merged 5 commits intobolt:masterfrom Oct 4, 2020
Merged
Add new bolt:reset-password CLI command to reset password#1937bobdenotter merged 5 commits intobolt:masterfrom
bolt:reset-password CLI command to reset password#1937bobdenotter merged 5 commits intobolt:masterfrom
Conversation
…lt/docs/blob/4.0/docs/howto/resetting-a-password.md), but not in the code. This is a simple version. Differences to the documentation: you have to specify the username (e-mail not possible) and you get the option of specifying a password yourself.
Contributor
Author
|
Reason to not implement username or email, but only username was to prevent having to specify what happens in edge-cases like someone having a username that is the same as someone else's email. |
JKetelaar
reviewed
Oct 3, 2020
JKetelaar
approved these changes
Oct 3, 2020
Contributor
Author
|
Ok, I've figured out how to run the coding style check locally - should have done that earlier. |
bobdenotter
approved these changes
Oct 4, 2020
Member
bobdenotter
left a comment
bobdenotter
left a comment
There was a problem hiding this comment.
Looking good! Thanks, @simongroenewolt 👍
bobdenotter
changed the title
bolt:reset-password CLI command to reset password
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset password command is in the documentation (https://github.com/bolt/docs/blob/4.0/docs/howto/resetting-a-password.md), but not in the code. This is a simple version. Differences to the documentation: you have to specify the username (e-mail not possible) and you get the option of specifying a password yourself.