Put back some more files that we really do need.#2022
Merged
Conversation
|
@bobdenotter Can you tag a new release, 4.1.2 is broken due to the absence of package.json |
Member
Author
|
@XWB What is broken, exactly? I didn't think it was needed in normal use (except for when you're building the assets yourself, which I assume most people don't do) |
|
Our pipeline fails because it cannot find package.json since 4.1.2: $ make build-assets
cd vendor/bolt/core && npm install && npm run build
npm WARN saveError ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm WARN core No description
npm WARN core No repository field.
npm WARN core No README data
npm WARN core No license field.
up to date in 0.313s
found 0 vulnerabilities
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path vendor/bolt/core/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open 'vendor/bolt/core/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! A complete log of this run can be found in:
npm ERR! /home/gitlab-runner/.npm/_logs/2020-10-21T11_15_21_125Z-debug.log
Makefile:20: recipe for target 'build-assets' failed
make: *** [build-assets] Error 254
Cleaning up file based variables
00:00
ERROR: Job failed: exit status 1 |
Member
Author
|
Why does your pipeline do this, instead of simply pulling in |
Member
Author
|
@XWB We've tagged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.