Changed name of generic taxonomy config file identifier#2029
Merged
I-Valchev merged 1 commit intobolt:masterfrom Oct 22, 2020
bfkolle:issue-TemplateChooserTaxonomyConfig
Merged
Changed name of generic taxonomy config file identifier#2029I-Valchev merged 1 commit intobolt:masterfrom bfkolle:issue-TemplateChooserTaxonomyConfig
I-Valchev merged 1 commit intobolt:masterfrom
bfkolle:issue-TemplateChooserTaxonomyConfig
Conversation
bobdenotter
approved these changes
Oct 22, 2020
Member
bobdenotter
left a comment
bobdenotter
left a comment
There was a problem hiding this comment.
Hi @bfkolle, thanks for the PR!
Good catch!
Member
|
hi @bfkolle , nice catch! Thanks for the PR, merging it in now 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't able to set the listing template for a taxonomy in taxonomy.yml. Did some snooping in the code and found that this line was referring to the taxonomy config by the wrong identifier. Just changed it to the new identifier and I could now set the listing template in my taxonomy.yml.
Hope I'm putting the pr in the right place, followed the instructions from the Contributing documentation online. There was no issue so I just named it after what I did.