Skip to content

Use CompletePackageInterface in BaseExtension#2507

Merged
I-Valchev merged 1 commit into4.1from
fix/CompletePackageInterface
Apr 2, 2021
Merged

Use CompletePackageInterface in BaseExtension#2507
I-Valchev merged 1 commit into4.1from
fix/CompletePackageInterface

Conversation

@bobdenotter
Copy link
Copy Markdown
Member

@bobdenotter bobdenotter commented Apr 2, 2021

Prevents:

Return value of Bolt\Extension\BaseExtension::getComposerPackage() must be an instance of Composer\Package\CompletePackage or null, instance of Composer\Package\AliasPackage returned

Schermafbeelding 2021-04-02 om 12 25 23

I-Valchev
I-Valchev approved these changes Apr 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch!

@I-Valchev I-Valchev merged commit 6447ca2 into 4.1 Apr 2, 2021
@I-Valchev I-Valchev deleted the fix/CompletePackageInterface branch April 2, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees

No one assigned

Labels

🐛 tag: bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobdenotter @I-Valchev