Fix datepicker to only attempt to use existing locales, ensuring Time Picking still works#2539
Merged
Fix datepicker to only attempt to use existing locales, ensuring Time Picking still works#2539
Conversation
… Picking still works
I-Valchev
reviewed
Apr 20, 2021
| {# Ensure we use only locales bundled with Flatflicker, otherwise default to 'en' #} | ||
| {% set locale = app.user.locale|split('_')|first %} | ||
| {% if not locale in 'ar|at|az|be|bg|bn|bs|cs|cy|da|de|eo|es|et|fa|fi|fo|fr|ga|gr|he|hi|hr|hu|id|is|it|ja|ka|km|ko|kz|lt|lv|mk|mn|ms|my|nl|no|pa|pl|pt|ro|ru|si|sk|sl|sq|sr|sv|th|tr|uk|uz|vn|zh'|split('|') %} | ||
| {% set locale = 'en' %} |
Member
There was a problem hiding this comment.
@bobdenotter is it an overkill to use the default locale, rather than en here? 🤔
Member
Author
There was a problem hiding this comment.
I hardcoded it, because if the default locale would be nl_NL, it'll still break in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.