Support Twig chain loaders if available#2660
Merged
bobdenotter merged 1 commit intobolt:4.1from Jul 1, 2021
Merged
Conversation
bobdenotter
approved these changes
Jul 1, 2021
Contributor
Author
|
Thanks @bobdenotter ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our Symfony bundles that we're testing on Bolt uses a custom Twig loader.
This results in
$this->getTwig()->getLoader()code used in Bolt in several places to return an instance ofTwig\Loader\ChainLoaderinstead ofTwig\Loader\FilesystemLoadermaking the code in question fail in Bolt, which results in Bolt not being able to find any of its templates.This fix adds support for
ChainLoader, which basically iterates over any Twig loader in the chain loader, and if it is an instance ofFilesystemLoader, does what Bolt did previously (adds or prepends a new path, based on context).Thanks to @ilukac for discovering the cause of the issue.