Skip to content

Update for SCSS deprecations#2861

Merged
bobdenotter merged 2 commits intomasterfrom
sass-depracations
Oct 13, 2021
Merged

Update for SCSS deprecations#2861
bobdenotter merged 2 commits intomasterfrom
sass-depracations

Conversation

@Joossensei
Copy link
Copy Markdown
Contributor

This should fix the npm run build deprecations

@Joossensei
Copy link
Copy Markdown
Contributor Author

Joossensei commented Oct 12, 2021

There is also a deprecation in the bootstrap node_module but this is something bootstrap should fix I think.

For that to that manually is to go to node_modules/bootstrap/scss/mixins/_forms.scss and edit line 121:

From:
background: $custom-select-background, $custom-select-bg escape-svg($icon) math.div($custom-select-feedback-icon-position, $custom-select-feedback-icon-size) no-repeat;

To:
background: $custom-select-background, $custom-select-bg escape-svg($icon) list.slash($custom-select-feedback-icon-position, $custom-select-feedback-icon-size) no-repeat;

Also add @use "sass:list" at the top of the file

Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop! One step further in cleaning up deprecations! 👍

@bobdenotter bobdenotter merged commit b35790c into master Oct 13, 2021
@bobdenotter bobdenotter deleted the sass-depracations branch October 13, 2021 09:51
@bobdenotter bobdenotter added the dependencies Pull requests that update a dependency file label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants