Skip to content

[issue-2901] fix(fixtures): non existent data mapped for fields of type select#2954

Merged
bobdenotter merged 2 commits intobolt:masterfrom
jbarbin:bugfix/issue-2901/select-fields-fixtures
Dec 3, 2021
Merged

[issue-2901] fix(fixtures): non existent data mapped for fields of type select#2954
bobdenotter merged 2 commits intobolt:masterfrom
jbarbin:bugfix/issue-2901/select-fields-fixtures

Conversation

@jbarbin
Copy link
Copy Markdown
Contributor

@jbarbin jbarbin commented Nov 21, 2021

These changes fix fixtures data for field of type select.

I saw a linked error for fields of type select mapped with a content type. Even if this fiels is not required, there are no empty option. That cause the reported error message for these field even on create content page.

Fixes #2901

Changelog

@jbarbin jbarbin changed the title [issue-2901] fix(fixtures): non existent data mapped for fields of type select Draft: [issue-2901] fix(fixtures): non existent data mapped for fields of type select Nov 21, 2021
@jbarbin jbarbin marked this pull request as draft November 21, 2021 00:47
@jbarbin jbarbin force-pushed the bugfix/issue-2901/select-fields-fixtures branch 2 times, most recently from 0509087 to b89f06a Compare November 21, 2021 01:00
@jbarbin jbarbin changed the title Draft: [issue-2901] fix(fixtures): non existent data mapped for fields of type select [issue-2901] fix(fixtures): non existent data mapped for fields of type select Nov 21, 2021
@jbarbin jbarbin marked this pull request as ready for review November 21, 2021 01:06
@jbarbin jbarbin force-pushed the bugfix/issue-2901/select-fields-fixtures branch from b89f06a to dd34798 Compare November 21, 2021 11:36
Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jbarbin,

I've assigned this issue to @Joossensei to review, since he opened the issue that this fixes.

Copy link
Copy Markdown
Contributor

@Joossensei Joossensei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

Copy link
Copy Markdown
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased it on master again. This PR should be good-to-go now. Thanks, @jbarbin

@bobdenotter bobdenotter merged commit 57936b8 into bolt:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bolt Fixtures create a selected option which doesnt exist

3 participants