Bootstrap upgrade from v4 to v5#3129
Merged
nestordedios merged 134 commits intomasterfrom May 3, 2022
Merged
Conversation
Collaborator
Author
|
When this changes are released this bobdenotter/configuration-notices#19 has to be released too. They are related |
Collaborator
Author
|
Hi 👋 !! This PR is ready to be reviewed and tested. The main thing this PR does is migrating from Bootstrap v4 to v5. It replaces the Bootbox library and uses Bootstrap modals instead and adds a couple of new translations Images and Files are no longer selected from a select list but from a modal displaying the different resources. See screencasts below: |
Collaborator
Author
|
As @Joossensei pointed out. The items in the list below need to be fixed before merging in.
|
bobdenotter
approved these changes
Apr 14, 2022
Member
bobdenotter
left a comment
bobdenotter
left a comment
There was a problem hiding this comment.
Great work, @nestordedios and @Joossensei 👍
Joossensei
force-pushed
the
upgrade/bootstrap-v5
branch
from
62a2647 to
8bd3be6
Compare
Some Bootstrap mixins do not accept $color variables as custom CSS variables. The hex value of the color needs to be passed instead
Bootstrap 5 adds text-decoration: underline to links by default. This commit removes the underline where we don't need it.
Bootstrap 5 dropdown buttons are now triggered using data-bs-toggle="dropdown" attribute
Also revert the phpstan 'fix'
Class update
Update db creation maybe it restores the files
Testing cypress on GH
Test Cypress on GH
Trying to fix this one
Oh there are 4
Revert and build a failsafe
bobdenotter
force-pushed
the
upgrade/bootstrap-v5
branch
from
e49b23c to
9dda14c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.