Merged
Conversation
Contributor
Author
|
Gotta fix the Cypress tests first |
Contributor
Author
|
The failing Cypress test seems to be failing only inside of Cypress not in a local checkout. |
Copy the file from Bolt 3 over and start editing from there
Validation is now done in PHP and some functions needed the removal of the ckeditor checks
No idea what they are for but I dont think we need or have them anymore
Also done in the backend via Twig
Also done in PHP
Copy the file from Bolt 3 over and start editing from there
Validation is now done in PHP and some functions needed the removal of the ckeditor checks
No idea what they are for but I dont think we need or have them anymore
Also done in the backend via Twig
Also done in PHP
Remove redundant code
Temp commit
"Don't get too deep, it leads to overthinking, and over thinking leads to problems that doesn't even exist in the first place." - Jayson Engay.
Because of this we can send the user to the just created page. Otherwise you'll stay on /bolt/new/contenttype
Added toast notification
Also create a toast on fail
Changed this function
Make duplication work
For Cypress
Keep vars in English
Gave user forms a different ID so the ajax wont get called on the user edit form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this new feature the saving of a record will be done on the background using jQuery ajax.
Requires a lot of testing.