Fix loading of modal text when removing collection item#3267
Merged
bobdenotter merged 2 commits intomasterfrom Jul 5, 2022
Merged
Fix loading of modal text when removing collection item#3267bobdenotter merged 2 commits intomasterfrom
bobdenotter merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3266
Using
event.currentTargetinstead ofevent.targetwe can target the button element to get thedata-attributevalues needed to populate the content of the modal even if the user click on the icon or text of the button.Using event delegation like
window.$(document).on('click', '[data-bs-toggle="modal"]', function(event)is what we need to make sure new added collection item remove buttons trigger the load of the modal text.