Remove deprecated implementations #3620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
remove-deprecated-implementations
branch
from
4f546a9 to
e54127e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated code that was marked for removal since Bolt 5.1, cleaning up the codebase by eliminating wrapper classes and unused methods.
Key changes:
- Removed four deprecated menu builder wrapper classes
- Removed deprecated
postLoadmethod fromFieldFillListener - Updated PHPStan baseline and UPGRADING.md documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Menu/StopwatchFrontendMenuBuilder.php | Removed deprecated wrapper class for FrontendMenu |
| src/Menu/StopwatchBackendMenuBuilder.php | Removed deprecated wrapper class for BackendMenu |
| src/Menu/CachedFrontendMenuBuilder.php | Removed deprecated wrapper class for FrontendMenu |
| src/Menu/CachedBackendMenuBuilder.php | Removed deprecated wrapper class for BackendMenu |
| src/Event/Listener/FieldFillListener.php | Removed deprecated empty postLoad method and unused import |
| phpstan-baseline.php | Removed PHPStan ignores for deleted menu builder classes |
| UPGRADING.md | Added documentation listing removed deprecated implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all code that was marked as deprecated.