This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Fix Windows bug - #6
Open
zone117x wants to merge 2 commits into
Open
Conversation
Owner
|
I'll try this on my windows box later. |
zone117x
marked this pull request as ready for review
May 19, 2020 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
I'm opening as a draft PR since this is a pretty hacky solution and I'm not thrilled with it, however, it does fix the issue on Windows.
The original bug reporter stated a similar issue was happening on a linux install. I suspect the problem is the same -- depending on how the Node.js installation is packaged, the
global-dirslib makes no sense in this context since this tool is targeting core Node.js components rather than user installed global modules.Alternative solution (?)
If the core node.js
node_modulesdirectory is always located at the location that thenpmornpxshell commands evaluate to, then a more elegant and cross platform solution could be using thewhichpackage to evaluate the location ofnpmand use that for locatinglibnpx.Thoughts?