[pull] main from apache:main#1061
Merged
pull[bot] merged 2 commits intoboost-entropy-python:mainfrom May 3, 2023
Merged
Conversation
This change adds full automation for keeping and updating min airflow version for all community providers. It makes sure that: * all non-preinstalled providers have min-airflow-version set properly * all providers (including the preinstalled ones) additionally perform a runtime check on whether correct version of Airflow is installed. * allows for exceptional cases for some providers to be set * all providers have `version` added and exported in their `__init__.py` Usually just setting the airflow version in requirements should be enough, but since we have to install runtime check for preinstalled providers, it's easier to add the runtime check for all providers, and it will be additional verification that airflow version is properly set. Additionally, we can export correct version in the automatically generated `__init__.py` for all providers. The pre-installed providers cannot have explicit minimum airflow version specified as requirement, because this would create a dependency cycle with Airflow, and while such dependency cycle is fine for `pip`, other tools that analyse dependencies get confused and produce errors, claiming there cannot be dependenc cycles in the dependency tree (which is not generally a hard requirement, package dependency graph does not have to be DAG and it can contain cycles). This is why we have to add runtime check in the preinstalled providers to fail when they are installed with older Airflow versions than the ones that are supported by our policy. This PR automates maintenance of all the versions involved during prepearation of release documentation - it has been somewhat manual procedure so far, because it was only set in provider.yaml, but since now we set it in several places, it requires automation and single source of truth (which is prepare_provider_packages.py script that is used for preparation of provider documenation and packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )