Skip to content

Conversation

@MarcelRaad
Copy link
Contributor

@MarcelRaad MarcelRaad commented Jul 19, 2016

MSVC complains about narrowing conversions and unreferences parameters.
This makes all tests almost level 4 warning clean on MSVC 14.

#include <iostream>
#include <list>
#include <vector>
#include <iterator>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::begin/end is came from C++11, so I think those should be replaced with boost::begin/end.

@MarcelRaad MarcelRaad changed the title Fix test compile breaks and warnings Fix MSVC warnings in tests Dec 30, 2022
@MarcelRaad
Copy link
Contributor Author

Rebased and removed the two commits which are already integrated. Only the warning fixes are left now.

@mclow
Copy link
Collaborator

mclow commented Dec 30, 2022

IIRC, the unsigned in hex is there to prevent warnings on other compilers.

@mclow
Copy link
Collaborator

mclow commented Dec 30, 2022

In the testX checks, I'd rather change dest to a size_t, since that's what std::distance returns.

MSVC complains about narrowing conversions and unreferences parameters.
This makes all tests almost level 4 warning clean on MSVC 14.
@MarcelRaad
Copy link
Contributor Author

IIRC, the unsigned in hex is there to prevent warnings on other compilers.

OK, I reverted that one.

In the testX checks, I'd rather change dest to a size_t, since that's what std::distance returns.

Right, that's better! It's ptrdiff_t rather than size_t, but it also applies to the operator+ used in the other tests. I changed that now.

@mclow mclow merged commit 3fe40eb into boostorg:develop Jan 1, 2023
@MarcelRaad MarcelRaad deleted the fix_tests branch January 1, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants