Increase gcc version for BOOST_NO_CXX11_ALIGNAS to 4.9 #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers (e.g. gcc 4.8) are known to require a literal constant in alignas and not supporting a constant expression. The test was modified to detect that.
gcc 4.8 is known to not support alignas with constant expressions.
Lastique
force-pushed
the
alignas_constexpr
branch
from
d86b2be to
c3f81f3
Compare
Lastique
added a commit
to boostorg/atomic
that referenced
this pull request
Mar 1, 2020
… expression gcc 4.8 requires that the argument of alignas is a literal constant and does not accept a constant expression. This workaround is temporary, until Boost.Config updates BOOST_NO_CXX11_ALIGNAS: boostorg/config#324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 4.8 appears to not support
alignasspecifier with a constant expression as an argument. This PR updates the test to detect this and increases gcc version to 4.9.