Skip to content

Improve the performance of our rounding step#1390

Merged
mborland merged 5 commits intodevelopfrom
perf
May 8, 2026
Merged

Improve the performance of our rounding step#1390
mborland merged 5 commits intodevelopfrom
perf

Conversation

@mborland
Copy link
Copy Markdown
Member

@mborland mborland commented May 7, 2026

Use grandlund Montgomery rather than divmod since the former is far faster with our larger, synthetic types

@mborland mborland self-assigned this May 7, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 97.90210% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.4%. Comparing base (697dbc7) to head (6899481).

Files with missing lines Patch % Lines
include/boost/decimal/detail/fenv_rounding.hpp 96.7% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1390     +/-   ##
=========================================
- Coverage     98.5%   98.4%   -0.0%     
=========================================
  Files          288     288             
  Lines        22831   22972    +141     
  Branches      1985    1997     +12     
=========================================
+ Hits         22473   22604    +131     
- Misses         358     368     +10     
Files with missing lines Coverage Δ
include/boost/decimal/decimal_fast128_t.hpp 96.0% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast32_t.hpp 97.3% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast64_t.hpp 97.5% <100.0%> (+0.1%) ⬆️
...e/boost/decimal/detail/cmath/impl/sqrt128_impl.hpp 100.0% <100.0%> (ø)
include/boost/decimal/detail/u256.hpp 82.5% <100.0%> (+1.6%) ⬆️
include/boost/decimal/detail/fenv_rounding.hpp 97.0% <96.7%> (-0.8%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697dbc7...6899481. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 713f015 into develop May 8, 2026
78 checks passed
@mborland mborland deleted the perf branch May 8, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant