Skip to content

Comments

Bugfix: missing imbue call can lead to crashes#9

Merged
eldiener merged 2 commits intoboostorg:developfrom
joachim-faulhaber:format_patches_1_59_0
Sep 23, 2015
Merged

Bugfix: missing imbue call can lead to crashes#9
eldiener merged 2 commits intoboostorg:developfrom
joachim-faulhaber:format_patches_1_59_0

Conversation

@joachim-faulhaber
Copy link
Contributor

No description provided.

@eldiener
Copy link
Contributor

Since 'loc_p' can be 0, it needs to be checked for non-zero before being dereferenced.

@joachim-faulhaber
Copy link
Contributor Author

Hmm, I thought that's what is done in the patch
if(loc_p) oss.imbue(*loc_p);
Would you prefer if(loc_p != nullptr) ?
BTW, here is a related ticket containing some more information on the issue:
https://svn.boost.org/trac/boost/ticket/7435

@eldiener
Copy link
Contributor

You are right. That's my mistake.

eldiener added a commit that referenced this pull request Sep 23, 2015
Bugfix: missing imbue call can lead to crashes
@eldiener eldiener merged commit 8023d13 into boostorg:develop Sep 23, 2015
@joachim-faulhaber joachim-faulhaber deleted the format_patches_1_59_0 branch September 24, 2015 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants