Some simplifications #1296
Some simplifications #1296
Conversation
| (turn.operations[0].seg_id.segment_index == 0 | ||
| && turn.operations[1].seg_id.segment_index == last_index); | ||
| return turn.operations[0].seg_id.segment_index == 0 | ||
| && turn.operations[1].seg_id.segment_index == last_index; |
There was a problem hiding this comment.
I think what was meant here was that the second condition had 1 vs 0 instead.
But it's hard to guess. I didn't write it (I think). @awulkiew ?
There was a problem hiding this comment.
OK, I kept the second condition with reversed 0 and 1.
Out of curiosity, is it possible for the second condition to be true in the way turns are computed in boost geometry?
There was a problem hiding this comment.
Yes, I think so. But maybe better to check that before merging it.
I'll try to check one of the coming days.
There was a problem hiding this comment.
@vissarion I forgot, and don't have the time to do it now in detail (it would require a quite specific testcase).
The operations are symmetric (have the same role) and unordered, so I'm quite sure it's right now.
Feel free to merge it.
barendgehrels
left a comment
barendgehrels
left a comment
There was a problem hiding this comment.
Thanks! One question but good looks
vissarion
force-pushed
the
fix/remove_unused
branch
from
c7a12cc to
9694cb5
Compare
vissarion
force-pushed
the
fix/remove_unused
branch
from
9694cb5 to
a4c05fd
Compare
2 participants
No description provided.