Skip to content

Conversation

@jeremy-murphy
Copy link
Contributor

@jeremy-murphy jeremy-murphy commented Oct 23, 2025

Not an actual dependency of the library. Discovered when I tried to make Boost.Geometry a dependency of Boost.Graph, the CMake breaks.

Not an actual dependency.
@jeremy-murphy
Copy link
Contributor Author

Sorry, might have opened this without doing proper research.

@jeremy-murphy jeremy-murphy reopened this Oct 23, 2025
@jeremy-murphy
Copy link
Contributor Author

OK, reopened now that I've put the Boost::crc dependency where it needs to go (on the unit tests).

@jeremy-murphy jeremy-murphy changed the title Remove Boost::crc dependency Move Boost::crc dependency from library to unit test Oct 23, 2025
@jeremy-murphy
Copy link
Contributor Author

jeremy-murphy commented Oct 23, 2025

The merge status is unknown and no amount of rechecking is fixing it, so I seem to be blocked from merging.

PS. Which, btw, is a status and button that only seems to appear on the mobile app; at least, I can't find it on the desktop version.

@jeremy-murphy
Copy link
Contributor Author

@barendgehrels are you able to merge this or does it require more approvals? I'm just getting an error from GitHub.

@barendgehrels
Copy link
Collaborator

@barendgehrels are you able to merge this or does it require more approvals? I'm just getting an error from GitHub.

I'll check.

@barendgehrels
Copy link
Collaborator

barendgehrels commented Oct 25, 2025

@barendgehrels are you able to merge this or does it require more approvals? I'm just getting an error from GitHub.

I'll check.

@jeremy-murphy it does not build for me, because some of the robustness tests don't go via boost_geometry_add_unit_test

It works if it is, instead, added in boost_geometry_add_robustness_test

Side note:
There is one additional optimization possible, because we can do exactly the same for program_options
But that requires two extra changes. I can do that in a follow-up if you want.

@barendgehrels
Copy link
Collaborator

barendgehrels commented Oct 25, 2025

@jeremy-murphy

Side note: There is one additional optimization possible, because we can do exactly the same for program_options But that requires two extra changes. I can do that in a follow-up if you want.

For convenience my diff (with branch develop):

diff_crc.txt

But ignore the removal of EXCLUDE_FROM_ALL

@jeremy-murphy jeremy-murphy changed the title Move Boost::crc dependency from library to unit test Move Boost::crc and Boost::program_options dependencies from library to unit and robustness tests Oct 25, 2025
@jeremy-murphy
Copy link
Contributor Author

program_options would cause the same problem, so I'll fix it here too.

target_link_libraries(${robustness_test_name}
PRIVATE
Boost::crc
Boost::program_options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version works for me, thanks.

I will merge it today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
I'm so used to merging things myself, I was a little confused when I couldn't find the merge button. 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants