Skip to content

Move Boost::crc and Boost::program_options dependencies from library to unit and robustness tests #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+12 −2
Open

Move Boost::crc and Boost::program_options dependencies from library to unit and robustness tests #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50a4cb4
Remove Boost::crc dependency
jeremy-murphy Oct 23, 2025
6186b9d
Add Boost::crc to unit test dependencies
jeremy-murphy Oct 23, 2025
6a6146f
Fix program_options; add crc to robustness test
jeremy-murphy Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ target_link_libraries(boost_geometry
Boost::concept_check
Boost::config
Boost::core
Boost::crc
Boost::function_types
Boost::graph
Boost::iterator
Expand All @@ -34,7 +33,6 @@ target_link_libraries(boost_geometry
Boost::mpl
Boost::multiprecision
Boost::numeric_conversion
Boost::program_options
Boost::qvm
Boost::range
Boost::rational
Expand Down
6 changes: 6 additions & 0 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ function(boost_geometry_add_unit_test prefix item)
PRIVATE
Boost::included_unit_test_framework)

# At least one unit test uses the crc library (but the Geometry library does not).
target_link_libraries(${unit_test_name}
PRIVATE
Boost::crc
Boost::program_options)

# Include the main Geometry test folder and the current folder
target_include_directories(${unit_test_name}
PRIVATE
Expand Down
6 changes: 6 additions & 0 deletions test/robustness/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ function(boost_geometry_add_robustness_test item)
PRIVATE
Boost::geometry)

# Link to additional libraries required for testing.
target_link_libraries(${robustness_test_name}
PRIVATE
Boost::crc
Boost::program_options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version works for me, thanks.

I will merge it today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!
I'm so used to merging things myself, I was a little confused when I couldn't find the merge button. 😂


# Include the main Geometry test folder and the current folder,
# and the robustness test folder
target_include_directories(${robustness_test_name}
Expand Down