-
Notifications
You must be signed in to change notification settings - Fork 226
Point-box and box-box distance for spherical and geographic CS #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dd meridian distance computation as special case
…nd sign of derivative
…bug in pt-sgmt distance strategy
a2fc360 to
a0b7839
Compare
|
Thanks! I'm ok with merging however I have 2 remarks:
|
I did the change following your suggestion. I am ok for now but in the future it is not very clear to have generic algorithms (i.e. for both geographic and spherical) hidden in spherical or at least be consistent in similar cases.
I agree, there are many issues with the naming of distance strategies. Maybe better in a different PR. |
|
Thanks. I noticed that you commented out So I'll merge this PR now and if needed tweak the includes afterwards. |
The code compiles as it is, that's why I commented out. Thanks. |
This PR adds support for point-box and box-box distance for spherical and geographic CS. It uses the meridian distance to compute distances from the horizontal line of a box and point-segment distance for distances to the vertical line.