Skip to content

Catch up with dms_parser change from function call operator to apply #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

Catch up with dms_parser change from function call operator to apply #786

merged 1 commit into from
Dec 23, 2020

Conversation

@mloskot
Copy link
Member

@mloskot mloskot commented Dec 22, 2020 •
edited
Loading

The change to dms_parser was applied in PR #394

This PR is required to make all examples compile, see #787

mloskot added a commit to mloskot/geometry that referenced this pull request Dec 22, 2020
@mloskot
Catch up examples with addition of robustness policy and others
3132933 
The example/c03_custom_linestring_example.cpp requires
change from PR boostorg#786
These changes make all examples compile again.
Fixes boostorg#784
@mloskot mloskot mentioned this pull request Dec 22, 2020
Merged
mloskot added a commit that referenced this pull request Dec 23, 2020
@mloskot
Catch up examples with addition of robustness policy and others (#787)
f615372 
The example/c03_custom_linestring_example.cpp requires change from PR #786
These changes make all examples compile again.
Fixes #784
barendgehrels
barendgehrels approved these changes Dec 23, 2020
View reviewed changes
Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a bit weird that this was apparently untested.
But it's an extension.

@mloskot mloskot mentioned this pull request Dec 23, 2020
Closed
@mloskot
Copy link
Member Author

mloskot commented Dec 23, 2020

It surprised me too.

I've taken a note to add one in #788

@mloskot mloskot merged commit b54a058 into boostorg:develop Dec 23, 2020
@mloskot mloskot deleted the ml/ext-algo-parse-fix-startegy-invocation branch December 23, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barendgehrels barendgehrels barendgehrels approved these changes

Assignees

No one assigned

Labels

bug extensions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mloskot @barendgehrels