Remove Boost.Assign usages.#416
Merged
jeremy-murphy merged 1 commit intoboostorg:developfrom Feb 10, 2025
Merged
Conversation
jeremy-murphy
approved these changes
Feb 6, 2025
Collaborator
jeremy-murphy
left a comment
jeremy-murphy
left a comment
There was a problem hiding this comment.
Thanks for a tidy improvement to the code! Just waiting for the tests to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boost.Assign is not needed C++14 code. This PR removes this library usages. It is also suggested to use
std::vectorstd::initializer_listconstructor instead of series ofpush_backcalls in test/two_graphs_common_spanning_trees_test.cpp.