Skip to content

Fix unused dead code in louvain_clustering.hpp#506

Merged
Becheler merged 2 commits into
boostorg:developfrom
Becheler:fix/louvain-unused-dead-code
Jun 8, 2026
Merged

Fix unused dead code in louvain_clustering.hpp#506
Becheler merged 2 commits into
boostorg:developfrom
Becheler:fix/louvain-unused-dead-code

Conversation

@Becheler
Copy link
Copy Markdown
Collaborator

@Becheler Becheler commented Jun 8, 2026

Refs #496

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Remove dead code in Louvain algorithm that was triggering warnings in CI.

Motivation

#496

Testing

Same CI, less warnings

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler changed the title Fix/louvain unused dead code Fix unused dead code in louvain_clustering.hpp Jun 8, 2026
@Becheler Becheler marked this pull request as ready for review June 8, 2026 09:41
@Becheler Becheler requested a review from jeremy-murphy as a code owner June 8, 2026 09:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2026

Compiler-warning counts vs develop (auto-generated).
PR run 27128957382 vs develop run 27127820287 (21cd4df091).

Job Baseline After Delta
macos (clang, 14) 75 48 -27
macos (clang, 17) 70 43 -27
macos (clang, 20) 70 43 -27
ubuntu (clang-19, 14) 75 48 -27
ubuntu (clang-19, 17) 75 48 -27
ubuntu (clang-19, 20) 75 48 -27
ubuntu (clang-19, 23) 75 48 -27
ubuntu (gcc-14, 14) 51 33 -18
ubuntu (gcc-14, 17) 51 33 -18
ubuntu (gcc-14, 20) 51 33 -18
ubuntu (gcc-14, 23) 51 33 -18
windows_msvc_14_3 (msvc-14.3) 1061 989 -72

@Becheler Becheler merged commit 5c61bd0 into boostorg:develop Jun 8, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant