Merged
Conversation
HDembinski
reviewed
Oct 26, 2019
HDembinski
reviewed
Oct 26, 2019
henryiii
force-pushed
the
henryiii-empty
branch
from
6582206 to
39f3ef6
Compare
HDembinski
reviewed
Oct 26, 2019
Collaborator
|
Otherwise looks very good. Almost ready to merge! |
henryiii
force-pushed
the
henryiii-empty
branch
from
39f3ef6 to
9babd4a
Compare
Contributor
Author
|
I think I see my mistake with the test. I can fix when I get home. |
Contributor
Author
|
I'm quite surprised clang allowed |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #241. I did not select a default for coverage, and I was not able to add one test that I wanted to due to bug #244 (not related to this PR, though).