Skip to content

Remove premature optimization #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HDembinski merged 1 commit into from
Sep 26, 2021
Merged

Remove premature optimization #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions include/boost/histogram/detail/fill_n.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,21 +241,11 @@ void fill_n_1(const std::size_t offset, S& storage, A& axes, const std::size_t v
bool all_inclusive = true;
for_each_axis(axes,
[&](const auto& ax) { all_inclusive &= axis::traits::inclusive(ax); });
if (axes_rank(axes) == 1) {
axis::visit(
[&](auto& ax) {
std::tuple<decltype(ax)> axes{ax};
fill_n_1(offset, storage, axes, vsize, values, std::forward<Us>(us)...);
},
axes[0]);
} else {
if (all_inclusive)
fill_n_nd<std::size_t>(offset, storage, axes, vsize, values,
std::forward<Us>(us)...);
else
fill_n_nd<optional_index>(offset, storage, axes, vsize, values,
std::forward<Us>(us)...);
}
if (all_inclusive)
fill_n_nd<std::size_t>(offset, storage, axes, vsize, values, std::forward<Us>(us)...);
else
fill_n_nd<optional_index>(offset, storage, axes, vsize, values,
std::forward<Us>(us)...);
}

template <class A, class T, std::size_t N>
Expand Down