Add regression tests for interval container lookup operations#53
Open
ldionne wants to merge 1 commit into
Open
Add regression tests for interval container lookup operations#53ldionne wants to merge 1 commit into
ldionne wants to merge 1 commit into
Conversation
Add tests to pin down the expected results of lower_bound, upper_bound, equal_range, and find on the various interval containers. These tests aim to trigger failures on some standard libraries (in particular newer versions of libc++) since Boost.ICL uses associative containers with a comparator that is not a proper strict weak ordering. Note that many tests already fail without these reproducers when upgrading to a newer libc++, but these tests provide additional coverage. Related to boostorg#51
joaquintides
added a commit
to joaquintides/icl
that referenced
this pull request
Mar 22, 2026
gl84
added a commit
to gl84/icl
that referenced
this pull request
Jun 9, 2026
The previous commit added the SWO-safe lower/upper_bound wrappers but left several call sites still using the raw container directly: find(), the BOOST_ASSERT in gap_insert, and the collision-range detection in the add/insert loops. Also adds the regression tests from PR boostorg#53 for broader coverage of the fixed accessors.
gl84
added a commit
to gl84/icl
that referenced
this pull request
Jun 27, 2026
The previous commit added the SWO-safe lower/upper_bound wrappers but left several call sites still using the raw container directly: find(), the BOOST_ASSERT in gap_insert, and the collision-range detection in the add/insert loops. Also adds the regression tests from PR boostorg#53 for broader coverage of the fixed accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests to pin down the expected results of lower_bound, upper_bound, equal_range, and find on the various interval containers. These tests aim to trigger failures on some standard libraries (in particular newer versions of libc++) since Boost.ICL uses associative containers with a comparator that is not a proper strict weak ordering.
Note that many tests already fail without these reproducers when upgrading to a newer libc++, but these tests provide additional coverage.
Related to #51