Skip to content

unified cmake test#71

Open
jll63 wants to merge 2 commits intoboostorg:developfrom
jll63:fix/cmake
Open

unified cmake test#71
jll63 wants to merge 2 commits intoboostorg:developfrom
jll63:fix/cmake

Conversation

@jll63
Copy link
Copy Markdown
Collaborator

@jll63 jll63 commented Apr 26, 2026

@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented Apr 26, 2026

An automated preview of the documentation is available at https://71.openmethod.prtest3.cppalliance.org/libs/openmethod/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-04-26 22:50:40 UTC

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates/updates the CMake-based integration test setup for Boost.OpenMethod to follow the “unified cmake test” pattern (tracking the referenced Boost.URL layout), replacing the previous cmake_subdir_test / cmake_install_test scaffolding.

Changes:

  • Add a unified test/cmake_test/ CMake project that supports multiple CI modes (install test, module install test, Boost superproject subdir test, and standalone add_subdirectory test).
  • Add a CMake-driven example program (test/cmake_test/main.cpp) exercising BOOST_OPENMETHOD dispatch.
  • Remove the older test/cmake_subdir_test/* and test/cmake_install_test/* CMake test files.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/cmake_test/main.cpp Adds the unified CMake test executable source demonstrating openmethod dispatch.
test/cmake_test/CMakeLists.txt Adds the unified CMake test driver with multiple CI configuration modes.
test/cmake_subdir_test/main.cpp Removed in favor of the unified cmake_test program.
test/cmake_subdir_test/CMakeLists.txt Removed in favor of unified multi-mode CMake logic.
test/cmake_install_test/CMakeLists.txt Removed; install/module install covered by unified cmake_test logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cmake_test/CMakeLists.txt Outdated
Comment thread test/cmake_test/CMakeLists.txt
Comment thread test/cmake_test/CMakeLists.txt
Comment thread test/cmake_test/CMakeLists.txt Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.34%. Comparing base (814a8e0) to head (99aa194).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    94.34%   94.34%           
========================================
  Files           43       43           
  Lines         2916     2916           
========================================
  Hits          2751     2751           
  Misses         165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e629b2f...99aa194. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cmake_test/CMakeLists.txt Outdated
@jll63
Copy link
Copy Markdown
Collaborator Author

jll63 commented Apr 26, 2026

@copilot apply changes based on the comments in this thread

@jll63 jll63 marked this pull request as ready for review April 26, 2026 22:13
@jll63 jll63 requested a review from Copilot April 26, 2026 22:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cmake_test/CMakeLists.txt Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cmake_test/CMakeLists.txt Outdated
Comment thread test/cmake_test/CMakeLists.txt Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/cmake_test/CMakeLists.txt Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants