Skip to content

Comments

C++11 variadics#34

Merged
djowel merged 44 commits intodevelopfrom
variadics
Aug 9, 2016
Merged

C++11 variadics#34
djowel merged 44 commits intodevelopfrom
variadics

Conversation

@Flast
Copy link
Collaborator

@Flast Flast commented Aug 9, 2016

I know this PR is very very huge, but there is no new changes, except remove unused headers (325604c), regenerate preprocessed files (0d3abcc) and changelog (d85b832).

This is not a breaking change, i.e. no user code should be changed.

I tested on

  • GCC 6.1.1 20160721 (Red Hat 6.1.1-4)
    • gnu++98 / 11 / 14 mode
  • clang 3.8.0
    • gnu++98 / 11 / 14 mode
  • MSVC
    • 8.0 (2005) - failed
    • 9.0 (2008) - passed
    • 10.0 (2010 SP1) - failed
    • 11.0 (2012 u5) - passed
    • 12.0 (2013 u5) - failed
    • 14.0 (2015 u2) - failed

I list all previous PRs for variadics.

I'll wait merging until it is approved.

djowel and others added 30 commits April 23, 2015 14:38
add a unit test for the observed issue.
Implement C++11 variadic templates based function_equal.
Implement variadic based phx2_result.
C++11 variadics based core/expression.
@djowel djowel merged commit 31fa037 into develop Aug 9, 2016
@Flast
Copy link
Collaborator Author

Flast commented Aug 9, 2016

Newer MSVC shows much of regressions. So, I'll fix those until 1.62 beta close.

@Flast Flast deleted the variadics branch August 9, 2016 22:15
@Lastique
Copy link
Member

Please, revert the change from develop (or fix it if it's quicker) because it breaks a lot of Boost.Log tests and seeing test results during the release cycle is essential.

http://www.boost.org/development/tests/develop/developer/output/teeks99-09e-win2012R2-64on64-boost-bin-v2-libs-log-test-~hdr-expressions-attr~hpp-test-msvc-12-0-dbg-adrs-mdl-64-thrd-mlt.html

@djowel
Copy link
Collaborator

djowel commented Aug 10, 2016

Ouch. @Flast, tell me if it's an easy fix, or we can revert for now.

@Flast
Copy link
Collaborator Author

Flast commented Aug 10, 2016

I think revert is best for now.

@Flast Flast mentioned this pull request Aug 10, 2016
@Flast
Copy link
Collaborator Author

Flast commented Aug 10, 2016

done. I'll investigate this weekend.

@Flast Flast restored the variadics branch August 13, 2016 02:11
@Flast Flast mentioned this pull request Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants